mirror of
https://github.com/crawlab-team/crawlab.git
synced 2026-01-21 17:21:09 +01:00
fix: improve logging in master and worker services
- Added logging for error handling in the MasterService when setting a worker node offline, replacing the previous trace.PrintError with a more informative log message. - Enhanced WorkerService subscription method with debug logs to indicate subscription attempts and status, improving traceability during connection processes.
This commit is contained in:
@@ -2,6 +2,7 @@ package service
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"github.com/apex/log"
|
||||
"github.com/cenkalti/backoff/v4"
|
||||
"github.com/crawlab-team/crawlab/core/constants"
|
||||
"github.com/crawlab-team/crawlab/core/grpc/server"
|
||||
@@ -17,7 +18,6 @@ import (
|
||||
"github.com/crawlab-team/crawlab/core/task/scheduler"
|
||||
"github.com/crawlab-team/crawlab/core/utils"
|
||||
"github.com/crawlab-team/crawlab/grpc"
|
||||
"github.com/crawlab-team/crawlab/trace"
|
||||
"go.mongodb.org/mongo-driver/bson"
|
||||
"go.mongodb.org/mongo-driver/bson/primitive"
|
||||
mongo2 "go.mongodb.org/mongo-driver/mongo"
|
||||
@@ -244,7 +244,7 @@ func (svc *MasterService) setWorkerNodeOffline(node *models.Node) {
|
||||
return service.NewModelService[models.Node]().ReplaceById(node.Id, *node)
|
||||
}, backoff.WithMaxRetries(backoff.NewConstantBackOff(1*time.Second), 3))
|
||||
if err != nil {
|
||||
trace.PrintError(err)
|
||||
log.Errorf("failed to set worker node[%s] offline: %v", node.Key, err)
|
||||
}
|
||||
svc.sendNotification(node)
|
||||
}
|
||||
|
||||
@@ -145,11 +145,13 @@ func (svc *WorkerService) subscribe() {
|
||||
|
||||
for {
|
||||
if svc.stopped {
|
||||
svc.Infof("subscription stopped. exiting...")
|
||||
return
|
||||
}
|
||||
|
||||
// Use backoff for connection attempts
|
||||
operation := func() error {
|
||||
svc.Debugf("attempting to subscribe to master")
|
||||
stream, err := client.GetGrpcClient().NodeClient.Subscribe(context.Background(), &grpc.NodeServiceSubscribeRequest{
|
||||
NodeKey: svc.cfgSvc.GetNodeKey(),
|
||||
})
|
||||
@@ -157,6 +159,7 @@ func (svc *WorkerService) subscribe() {
|
||||
svc.Errorf("failed to subscribe to master: %v", err)
|
||||
return err
|
||||
}
|
||||
svc.Debugf("subscribed to master")
|
||||
|
||||
// Handle messages
|
||||
for {
|
||||
|
||||
Reference in New Issue
Block a user