git-sync/crawlab
1
0
Fork 0
mirror of https://github.com/crawlab-team/crawlab.git synced 2026-01-22 17:31:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Refactor IM notification function to improve code structure and readability

Browse Source
This commit is contained in:
Marvin Zhang
2024-07-25 16:50:03 +08:00
parent df563a5e2d
commit eef3eea777
1 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
core/notification/im.go
View File

@@ -89,12 +89,12 @@ func getIMRequestHeader() req.Header {
}
}
func performIMRequest[T any](webhookUrl string, data req.Param) (resBody T, err error) {
func performIMRequest(webhookUrl string, data req.Param) (res *req.Resp, err error) {
// perform request
res, err := req.Post(webhookUrl, getIMRequestHeader(), req.BodyJSON(&data))
res, err = req.Post(webhookUrl, getIMRequestHeader(), req.BodyJSON(&data))
if err != nil {
log.Errorf("IM request error: %v", err)
return resBody, err
return nil, err
}
// get response
@@ -103,7 +103,16 @@ func performIMRequest[T any](webhookUrl string, data req.Param) (resBody T, err
// check status code
if response.StatusCode >= 400 {
log.Errorf("IM response status code: %d", res.Response().StatusCode)
return resBody, errors.New(fmt.Sprintf("IM error response %d: %s", response.StatusCode, res.String()))
return nil, errors.New(fmt.Sprintf("IM error response %d: %s", response.StatusCode, res.String()))
}
return res, nil
}
func performIMRequestWithJson[T any](webhookUrl string, data req.Param) (resBody T, err error) {
res, err := performIMRequest(webhookUrl, data)
if err != nil {
return resBody, err
}
// parse response
@@ -202,7 +211,7 @@ func sendIMLark(ch *models.NotificationChannelV2, title, content string) error {
},
},
}
resBody, err := performIMRequest[ResBody](ch.WebhookUrl, data)
resBody, err := performIMRequestWithJson[ResBody](ch.WebhookUrl, data)
if err != nil {
return err
}
@@ -219,7 +228,7 @@ func sendIMSlack(ch *models.NotificationChannelV2, title, content string) error
{"type": "section", "text": req.Param{"type": "mrkdwn", "text": convertMarkdownToSlack(content)}},
},
}
resBody, err := performIMRequest[ResBody](ch.WebhookUrl, data)
resBody, err := performIMRequestWithJson[ResBody](ch.WebhookUrl, data)
if err != nil {
return err
}
@@ -237,7 +246,7 @@ func sendIMDingTalk(ch *models.NotificationChannelV2, title string, content stri
"text": fmt.Sprintf("# %s\n\n%s", title, content),
},
}
resBody, err := performIMRequest[ResBody](ch.WebhookUrl, data)
resBody, err := performIMRequestWithJson[ResBody](ch.WebhookUrl, data)
if err != nil {
return err
}
@@ -254,7 +263,7 @@ func sendIMWechatWork(ch *models.NotificationChannelV2, title string, content st
"content": fmt.Sprintf("# %s\n\n%s", title, content),
},
}
resBody, err := performIMRequest[ResBody](ch.WebhookUrl, data)
resBody, err := performIMRequestWithJson[ResBody](ch.WebhookUrl, data)
if err != nil {
return err
}
@@ -293,13 +302,10 @@ func sendIMTelegram(ch *models.NotificationChannelV2, title string, content stri
}
// perform request
resBody, err := performIMRequest[ResBody](webhookUrl, data)
_, err := performIMRequest(webhookUrl, data)
if err != nil {
return err
}
if !resBody.Ok {
return errors.New(resBody.Description)
}
return nil
}
@@ -312,13 +318,10 @@ func sendIMDiscord(ch *models.NotificationChannelV2, title string, content strin
},
},
}
resBody, err := performIMRequest[ResBody](ch.WebhookUrl, data)
_, err := performIMRequest(ch.WebhookUrl, data)
if err != nil {
return err
}
if resBody.ErrCode != 0 {
return errors.New(resBody.ErrMsg)
}
return nil
}
@@ -335,7 +338,7 @@ func sendIMMSTeams(ch *models.NotificationChannelV2, title string, content strin
"body": []req.Param{
{
"type": "TextBlock",
"text": title,
"text": fmt.Sprintf("**%s**", title),
},
{
"type": "TextBlock",
@@ -345,12 +348,9 @@ func sendIMMSTeams(ch *models.NotificationChannelV2, title string, content strin
},
}},
}
resBody, err := performIMRequest[ResBody](ch.WebhookUrl, data)
_, err := performIMRequest(ch.WebhookUrl, data)
if err != nil {
return err
}
if resBody.ErrCode != 0 {
return errors.New(resBody.ErrMsg)
}
return nil
}