git-sync/crawlab
1
0
Fork 0
mirror of https://github.com/crawlab-team/crawlab.git synced 2026-01-21 17:21:09 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improve logging in gRPC services by removing service prefixes

Browse Source 
- Updated log messages in NodeServiceServer and TaskServiceServer to remove the "[NodeServiceServer]" and "[TaskServiceServer]" prefixes for cleaner output.
- This change enhances log readability and maintains consistency across logging practices in the application.
This commit is contained in:
Marvin Zhang
2024-12-31 13:30:02 +08:00
parent 3786ef3f6d
commit 25fe273a62
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/grpc/server/node_service_server.go
View File

@@ -51,7 +51,7 @@ func (svr NodeServiceServer) Register(_ context.Context, req *grpc.NodeServiceRe
if err != nil {
return HandleError(err)
}
svr.Infof("[NodeServiceServer] updated worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
svr.Infof("updated worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
} else if errors2.Is(err, mongo.ErrNoDocuments) {
// register new
node = &models.Node{
@@ -69,13 +69,13 @@ func (svr NodeServiceServer) Register(_ context.Context, req *grpc.NodeServiceRe
if err != nil {
return HandleError(err)
}
svr.Infof("[NodeServiceServer] added worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
svr.Infof("added worker[%s] in db. id: %s", req.NodeKey, node.Id.Hex())
} else {
// error
return HandleError(err)
}
svr.Infof("[NodeServiceServer] master registered worker[%s]", req.NodeKey)
svr.Infof("master registered worker[%s]", req.NodeKey)
return HandleSuccessWithData(node)
}
@@ -113,12 +113,12 @@ func (svr NodeServiceServer) SendHeartbeat(_ context.Context, req *grpc.NodeServ
}
func (svr NodeServiceServer) Subscribe(request *grpc.NodeServiceSubscribeRequest, stream grpc.NodeService_SubscribeServer) (err error) {
svr.Infof("[NodeServiceServer] master received subscribe request from node[%s]", request.NodeKey)
svr.Infof("master received subscribe request from node[%s]", request.NodeKey)
// find in db
node, err := service.NewModelService[models.Node]().GetOne(bson.M{"key": request.NodeKey}, nil)
if err != nil {
svr.Errorf("[NodeServiceServer] error getting node: %v", err)
svr.Errorf("error getting node: %v", err)
return err
}
@@ -136,7 +136,7 @@ func (svr NodeServiceServer) Subscribe(request *grpc.NodeServiceSubscribeRequest
nodeServiceMutex.Lock()
delete(svr.subs, node.Id)
nodeServiceMutex.Unlock()
svr.Infof("[NodeServiceServer] master unsubscribed from node[%s]", request.NodeKey)
svr.Infof("master unsubscribed from node[%s]", request.NodeKey)
return nil
}

2
core/grpc/server/task_service_server.go
View File

@@ -62,7 +62,7 @@ func (svr TaskServiceServer) Subscribe(req *grpc.TaskServiceSubscribeRequest, st
taskServiceMutex.Lock()
delete(svr.subs, taskId)
taskServiceMutex.Unlock()
svr.Infof("[TaskServiceServer] task stream closed: %s", taskId.Hex())
svr.Infof("task stream closed: %s", taskId.Hex())
return nil
}