From f08d5aa73b40964804364bf0e0497455ea4a2293 Mon Sep 17 00:00:00 2001 From: Sam Chau Date: Tue, 3 Sep 2024 18:25:22 +0930 Subject: [PATCH] fix: stop saving settings on bad clone --- backend/app/settings.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/backend/app/settings.py b/backend/app/settings.py index a16871a..1a6b39f 100644 --- a/backend/app/settings.py +++ b/backend/app/settings.py @@ -570,11 +570,14 @@ def update_settings(): logger.error(f"Missing required field: {field}") return jsonify({"error": f"Missing required field: {field}"}), 400 - save_settings(new_settings) - settings_manager.__init__() + # Attempt to clone the repository before saving settings + settings_manager.settings = new_settings + settings_manager.repo_url = new_settings['gitRepo'] success, message = settings_manager.clone_repository() if success: + # Only save the settings if the clone was successful + save_settings(new_settings) logger.info("Settings updated and repository cloned successfully") return jsonify(new_settings), 200 else: