From e6723293709d205211f3dc9b7ec5a26a89fa4d82 Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@163.com>
Date: Sun, 14 Jul 2024 23:25:31 +0800
Subject: [PATCH] refactor: Update SendNotification function to handle old and
 new settings triggers

---
 core/grpc/server/task_server_v2.go | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/core/grpc/server/task_server_v2.go b/core/grpc/server/task_server_v2.go
index 80691492..68cadaf9 100644
--- a/core/grpc/server/task_server_v2.go
+++ b/core/grpc/server/task_server_v2.go
@@ -138,7 +138,14 @@ func (svr TaskServerV2) SendNotification(ctx context.Context, request *grpc.Requ
 		return nil, trace.TraceError(err)
 	}
 	for _, s := range settings {
-		switch s.TaskTrigger {
+		// compatible with old settings
+		trigger := s.Trigger
+		if trigger == "" {
+			trigger = s.TaskTrigger
+		}
+
+		// send notification
+		switch trigger {
 		case constants.NotificationTriggerTaskFinish:
 			if t.Status != constants.TaskStatusPending && t.Status != constants.TaskStatusRunning {
 				_ = svc.Send(&s, e)