git-sync/crawlab
1
0
Fork 0
mirror of https://github.com/crawlab-team/crawlab.git synced 2026-01-27 17:50:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: update method receivers to value type for cleanup and connection methods; enhance context usage for task client operations

Browse Source
This commit is contained in:
Marvin Zhang
2025-08-07 11:53:42 +08:00
parent f5f83a010f
commit e1251d808b
3 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/task/handler/runner.go
View File

@@ -123,6 +123,7 @@ type Runner struct {
cancel context.CancelFunc // function to cancel the context
done chan struct{} // channel to signal completion
wg sync.WaitGroup // wait group for goroutine synchronization
// connection management for robust task execution
connMutex sync.RWMutex // mutex for connection access
connHealthTicker *time.Ticker // ticker for connection health checks
@@ -533,7 +534,7 @@ func (r *Runner) initConnection() (err error) {
r.Errorf("failed to get task client: %v", err)
return err
}
r.conn, err = taskClient.Connect(context.Background())
r.conn, err = taskClient.Connect(r.ctx)
if err != nil {
r.Errorf("error connecting to task service: %v", err)
return err
@@ -657,7 +658,7 @@ func (r *Runner) reconnectWithRetry() error {
r.Warnf("reconnection attempt %d failed to get task client: %v", attempt+1, err)
continue
}
conn, err := taskClient.Connect(context.Background())
conn, err := taskClient.Connect(r.ctx)
if err != nil {
r.Warnf("reconnection attempt %d failed: %v", attempt+1, err)
continue
@@ -730,7 +731,9 @@ func (r *Runner) sendNotification() {
r.Errorf("failed to get task client: %v", err)
return
}
_, err = taskClient.SendNotification(context.Background(), req)
ctx, cancel := context.WithTimeout(r.ctx, 10*time.Second)
defer cancel()
_, err = taskClient.SendNotification(ctx, req)
if err != nil {
r.Errorf("error sending notification: %v", err)
return