From ab1dcf45efab1c282adfcbcc64dfbbdb9a731ce6 Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@gmail.com>
Date: Mon, 17 Jun 2019 13:01:20 +0800
Subject: [PATCH 1/7] updated crontab

---
 frontend/package.json                        |  1 +
 frontend/src/views/schedule/ScheduleList.vue | 29 +++++++++++++++++---
 frontend/yarn.lock                           | 20 ++++++++++++++
 3 files changed, 46 insertions(+), 4 deletions(-)

diff --git a/frontend/package.json b/frontend/package.json
index 42bcf078..7b75b711 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -22,6 +22,7 @@
     "normalize.css": "7.0.0",
     "nprogress": "0.2.0",
     "path": "^0.12.7",
+    "vcrontab": "^0.3.3",
     "vue": "^2.5.22",
     "vue-ba": "^1.2.5",
     "vue-codemirror-lite": "^1.0.4",
diff --git a/frontend/src/views/schedule/ScheduleList.vue b/frontend/src/views/schedule/ScheduleList.vue
index 7a1fc9ba..377fe6b7 100644
--- a/frontend/src/views/schedule/ScheduleList.vue
+++ b/frontend/src/views/schedule/ScheduleList.vue
@@ -29,12 +29,17 @@
               </span>
             </el-tooltip>
           </template>
-          <el-input v-model="scheduleForm.cron" :placeholder="$t('Cron')"></el-input>
+          <el-input style="width:calc(100% - 100px);padding-right:10px"
+                    v-model="scheduleForm.cron"
+                    :placeholder="$t('Cron')">
+          </el-input>
+          <el-button style="width:100px" type="primary" @click="onShowCronDialog">{{$t('生成Cron')}}</el-button>
         </el-form-item>
         <el-form-item :label="$t('Execute Command')" prop="params">
           <el-input v-model="spider.cmd"
                     :placeholder="$t('Execute Command')"
-                    disabled></el-input>
+                    disabled>
+          </el-input>
         </el-form-item>
         <el-form-item :label="$t('Parameters')" prop="params">
           <el-input v-model="scheduleForm.params"
@@ -51,6 +56,11 @@
       </span>
     </el-dialog>
 
+    <!--cron generation popup-->
+    <el-dialog title="生成 Cron" :visible.sync="showCron">
+      <vcrontab @hide="showCron=false" @fill="onCrontabFill" :expression="expression"></vcrontab>
+    </el-dialog>
+
     <!--filter-->
     <div class="filter">
       <div class="right">
@@ -95,17 +105,19 @@
 </template>
 
 <script>
+import vcrontab from 'vcrontab'
 import {
   mapState
 } from 'vuex'
 
 export default {
   name: 'ScheduleList',
+  components: { vcrontab },
   data () {
     const cronValidator = (rule, value, callback) => {
       let patArr = []
       for (let i = 0; i < 6; i++) {
-        patArr.push('[/*,0-9]+')
+        patArr.push('[/*,0-9-]+')
       }
       const pat = '^' + patArr.join(' ') + '$'
       if (!value) {
@@ -126,7 +138,9 @@ export default {
       dialogVisible: false,
       cronRules: [
         { validator: cronValidator, trigger: 'blur' }
-      ]
+      ],
+      showCron: false,
+      expression: ''
     }
   },
   computed: {
@@ -201,6 +215,13 @@ export default {
       this.$st.sendEv('定时任务', '删除', 'id', row._id)
     },
     onCrawl () {
+    },
+    onCrontabFill (value) {
+      this.$set(this.scheduleForm, 'cron', value)
+    },
+    onShowCronDialog () {
+      this.showCron = true
+      this.expression = this.scheduleForm.cron
     }
   },
   created () {
diff --git a/frontend/yarn.lock b/frontend/yarn.lock
index 2d266229..631bffcd 100644
--- a/frontend/yarn.lock
+++ b/frontend/yarn.lock
@@ -2910,6 +2910,18 @@ element-ui@2.4.6:
     resize-observer-polyfill "^1.5.0"
     throttle-debounce "^1.0.1"
 
+element-ui@^2.4.11:
+  version "2.9.1"
+  resolved "https://registry.npm.taobao.org/element-ui/download/element-ui-2.9.1.tgz#a05f2e76023d529ba0dfa2d03ae16e5134b20c4e"
+  integrity sha1-oF8udgI9Upug36LQOuFuUTSyDE4=
+  dependencies:
+    async-validator "~1.8.1"
+    babel-helper-vue-jsx-merge-props "^2.0.0"
+    deepmerge "^1.2.0"
+    normalize-wheel "^1.0.1"
+    resize-observer-polyfill "^1.5.0"
+    throttle-debounce "^1.0.1"
+
 elliptic@^6.0.0:
   version "6.4.1"
   resolved "http://registry.npm.taobao.org/elliptic/download/elliptic-6.4.1.tgz#c2d0b7776911b86722c632c3c06c60f2f819939a"
@@ -8383,6 +8395,14 @@ vary@~1.1.2:
   version "1.1.2"
   resolved "http://registry.npm.taobao.org/vary/download/vary-1.1.2.tgz#2299f02c6ded30d4a5961b0b9f74524a18f634fc"
 
+vcrontab@^0.3.3:
+  version "0.3.3"
+  resolved "https://registry.npm.taobao.org/vcrontab/download/vcrontab-0.3.3.tgz#c4cd48e6d1a74c9bb8d693f7b732463e8eebdef5"
+  integrity sha1-xM1I5tGnTJu41pP3tzJGPo7r3vU=
+  dependencies:
+    element-ui "^2.4.11"
+    vue "^2.5.17"
+
 vendors@^1.0.0:
   version "1.0.2"
   resolved "http://registry.npm.taobao.org/vendors/download/vendors-1.0.2.tgz#7fcb5eef9f5623b156bcea89ec37d63676f21801"

From 9b67e1fc2839c4f2a8834c9c1268e026dc17d158 Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@gmail.com>
Date: Mon, 17 Jun 2019 13:02:28 +0800
Subject: [PATCH 2/7] updated CHANGELOG

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8d4cfe09..dc2c3eb6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # 0.2.4 (unreleased)
 - **Documentation**: Better and much more detailed documentation.
+- **Better Crontab**: Make crontab expression through crontab UI.
 
 
 # 0.2.3 (2019-06-12)

From aa3911f9fab73c0c1de2b189a73c5dee4b026933 Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@gmail.com>
Date: Mon, 17 Jun 2019 13:04:17 +0800
Subject: [PATCH 3/7] updated crontab

---
 frontend/src/views/schedule/ScheduleList.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/views/schedule/ScheduleList.vue b/frontend/src/views/schedule/ScheduleList.vue
index 377fe6b7..06fddc26 100644
--- a/frontend/src/views/schedule/ScheduleList.vue
+++ b/frontend/src/views/schedule/ScheduleList.vue
@@ -117,7 +117,7 @@ export default {
     const cronValidator = (rule, value, callback) => {
       let patArr = []
       for (let i = 0; i < 6; i++) {
-        patArr.push('[/*,0-9-]+')
+        patArr.push('[/*,0-9-\?]+')
       }
       const pat = '^' + patArr.join(' ') + '$'
       if (!value) {

From 8e3d7be5ad306443a8af2818cd2ed1073288b6f5 Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@gmail.com>
Date: Mon, 17 Jun 2019 13:04:29 +0800
Subject: [PATCH 4/7] updated crontab

---
 frontend/src/views/schedule/ScheduleList.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/views/schedule/ScheduleList.vue b/frontend/src/views/schedule/ScheduleList.vue
index 06fddc26..f5e8f4f0 100644
--- a/frontend/src/views/schedule/ScheduleList.vue
+++ b/frontend/src/views/schedule/ScheduleList.vue
@@ -117,7 +117,7 @@ export default {
     const cronValidator = (rule, value, callback) => {
       let patArr = []
       for (let i = 0; i < 6; i++) {
-        patArr.push('[/*,0-9-\?]+')
+        patArr.push('[/*,0-9-?]+')
       }
       const pat = '^' + patArr.join(' ') + '$'
       if (!value) {

From 67a82f03703d062a21822a67724897318af9f4a8 Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@gmail.com>
Date: Mon, 17 Jun 2019 13:06:47 +0800
Subject: [PATCH 5/7] updated crontab

---
 frontend/src/views/schedule/ScheduleList.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/views/schedule/ScheduleList.vue b/frontend/src/views/schedule/ScheduleList.vue
index f5e8f4f0..377fe6b7 100644
--- a/frontend/src/views/schedule/ScheduleList.vue
+++ b/frontend/src/views/schedule/ScheduleList.vue
@@ -117,7 +117,7 @@ export default {
     const cronValidator = (rule, value, callback) => {
       let patArr = []
       for (let i = 0; i < 6; i++) {
-        patArr.push('[/*,0-9-?]+')
+        patArr.push('[/*,0-9-]+')
       }
       const pat = '^' + patArr.join(' ') + '$'
       if (!value) {

From c4ced4316eb379630134c99e93b1592e8992332d Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@gmail.com>
Date: Mon, 17 Jun 2019 13:14:51 +0800
Subject: [PATCH 6/7] updated crontab

---
 frontend/src/views/schedule/ScheduleList.vue | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/frontend/src/views/schedule/ScheduleList.vue b/frontend/src/views/schedule/ScheduleList.vue
index 377fe6b7..19b300a3 100644
--- a/frontend/src/views/schedule/ScheduleList.vue
+++ b/frontend/src/views/schedule/ScheduleList.vue
@@ -119,7 +119,7 @@ export default {
       for (let i = 0; i < 6; i++) {
         patArr.push('[/*,0-9-]+')
       }
-      const pat = '^' + patArr.join(' ') + '$'
+      const pat = '^' + patArr.join(' ') + '( [/*,0-9-]+)?' + '$'
       if (!value) {
         callback(new Error('cron cannot be empty'))
       } else if (!value.match(pat)) {
@@ -217,11 +217,18 @@ export default {
     onCrawl () {
     },
     onCrontabFill (value) {
+      value = value.replace(/[?]/g, '*')
       this.$set(this.scheduleForm, 'cron', value)
     },
     onShowCronDialog () {
       this.showCron = true
-      this.expression = this.scheduleForm.cron
+      if (this.expression.split(' ').length < 7) {
+        // this.expression = (this.scheduleForm.cron + ' ').replace(/[?]/g, '*')
+        this.expression = this.scheduleForm.cron + ' '
+      } else {
+        // this.expression = this.scheduleForm.cron.replace(/[?]/g, '*')
+        this.expression = this.scheduleForm.cron
+      }
     }
   },
   created () {

From 92db61641952df6ca6a286ba2d488661f3ba7cf3 Mon Sep 17 00:00:00 2001
From: Marvin Zhang <tikazyq@gmail.com>
Date: Mon, 17 Jun 2019 13:18:51 +0800
Subject: [PATCH 7/7] updated crontab

---
 frontend/src/views/schedule/ScheduleList.vue | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/frontend/src/views/schedule/ScheduleList.vue b/frontend/src/views/schedule/ScheduleList.vue
index 19b300a3..870a70b0 100644
--- a/frontend/src/views/schedule/ScheduleList.vue
+++ b/frontend/src/views/schedule/ScheduleList.vue
@@ -219,6 +219,8 @@ export default {
     onCrontabFill (value) {
       value = value.replace(/[?]/g, '*')
       this.$set(this.scheduleForm, 'cron', value)
+
+      this.$st.sendEv('定时任务', '提交生成Cron', 'cron', this.scheduleForm.cron)
     },
     onShowCronDialog () {
       this.showCron = true
@@ -229,6 +231,8 @@ export default {
         // this.expression = this.scheduleForm.cron.replace(/[?]/g, '*')
         this.expression = this.scheduleForm.cron
       }
+
+      this.$st.sendEv('定时任务', '点击生成Cron', 'cron', this.scheduleForm.cron)
     }
   },
   created () {