git-sync/crawlab
1
0
Fork 0
mirror of https://github.com/crawlab-team/crawlab.git synced 2026-02-01 18:20:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: update filter constants and improve type handling in filter functions

Browse Source 
- Renamed filter operation constants for clarity and consistency.
- Introduced short forms for certain filter operations.
- Updated test cases to reflect changes in filter operation handling.
- Enhanced type handling in filter functions to support int64 values for conditions.
- Improved query generation logic to accommodate new constant names and types.
This commit is contained in:
Marvin Zhang
2025-03-16 20:30:52 +08:00
parent ce0143ca06
commit 700c263cfe
4 changed files with 51 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/controllers/utils_test.go
View File

@@ -34,7 +34,7 @@ func TestGetFilterFromConditionString(t *testing.T) {
assert.Equal(t, "test", filter.Conditions[0].Value)
assert.Equal(t, "priority", filter.Conditions[1].Key)
assert.Equal(t, "gt", filter.Conditions[1].Op)
assert.Equal(t, float64(5), filter.Conditions[1].Value) // JSON parses numbers as float64
assert.Equal(t, int64(5), filter.Conditions[1].Value)
// Invalid JSON should return error
condStr = `[{"key":"name","op":"eq","value":"test"`
@@ -56,7 +56,7 @@ func TestGetFilterQueryFromConditionString(t *testing.T) {
query, err = controllers.GetFilterQueryFromConditionString(condStr)
require.NoError(t, err)
require.NotNil(t, query)
expected = bson.M{"priority": bson.M{"$gt": float64(5)}}
expected = bson.M{"priority": bson.M{"$gt": int64(5)}}
assert.Equal(t, expected, query)
// Multiple conditions
@@ -64,11 +64,11 @@ func TestGetFilterQueryFromConditionString(t *testing.T) {
query, err = controllers.GetFilterQueryFromConditionString(condStr)
require.NoError(t, err)
require.NotNil(t, query)
expected = bson.M{"name": "test", "priority": bson.M{"$gt": float64(5)}}
expected = bson.M{"name": "test", "priority": bson.M{"$gt": int64(5)}}
assert.Equal(t, expected, query)
// Contains operator
condStr = `[{"key":"name","op":"contains","value":"test"}]`
condStr = `[{"key":"name","op":"c","value":"test"}]`
query, err = controllers.GetFilterQueryFromConditionString(condStr)
require.NoError(t, err)
require.NotNil(t, query)