git-sync/crawlab
1
0
Fork 0
mirror of https://github.com/crawlab-team/crawlab.git synced 2026-02-01 18:20:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: standardize response types across controllers

Browse Source 
- Updated multiple controller methods to return VoidResponse instead of generic Response[any].
- Consolidated error handling to utilize GetErrorVoidResponse for consistent error responses.
- Enhanced parameter handling in export and file management functions for improved clarity and maintainability.
- Refactored health check and login/logout methods to align with new response structure.
- Improved overall consistency in response formatting across various endpoints.
This commit is contained in:
Marvin Zhang
2025-03-16 22:25:13 +08:00
parent 700c263cfe
commit 43d1c7692b
16 changed files with 175 additions and 135 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
core/controllers/base_file.go
View File

@@ -62,46 +62,46 @@ type PostBaseFileSaveOneParams struct {
Data string `json:"data"`
}
func PostBaseFileSaveOne(rootPath, path, data string) (response *Response[any], err error) {
func PostBaseFileSaveOne(rootPath, path, data string) (response *VoidResponse, err error) {
fsSvc, err := fs.GetBaseFileFsSvc(rootPath)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
if err := fsSvc.Save(path, []byte(data)); err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
return GetDataResponse(any(data))
return GetVoidResponse()
}
func PostBaseFileSaveOneForm(rootPath, path string, file *multipart.FileHeader) (response *Response[any], err error) {
func PostBaseFileSaveOneForm(rootPath, path string, file *multipart.FileHeader) (response *VoidResponse, err error) {
fsSvc, err := fs.GetBaseFileFsSvc(rootPath)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
f, err := file.Open()
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
fileData, err := io.ReadAll(f)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
if err := fsSvc.Save(path, fileData); err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
return GetDataResponse[any](nil)
return GetVoidResponse()
}
func PostBaseFileSaveMany(rootPath string, form *multipart.Form) (response *Response[any], err error) {
func PostBaseFileSaveMany(rootPath string, form *multipart.Form) (response *VoidResponse, err error) {
fsSvc, err := fs.GetBaseFileFsSvc(rootPath)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
wg := sync.WaitGroup{}
@@ -140,67 +140,67 @@ func PostBaseFileSaveMany(rootPath string, form *multipart.Form) (response *Resp
}
wg.Wait()
return GetDataResponse[any](nil)
return GetVoidResponse()
}
func PostBaseFileSaveDir(rootPath, path string) (response *Response[any], err error) {
func PostBaseFileSaveDir(rootPath, path string) (response *VoidResponse, err error) {
fsSvc, err := fs.GetBaseFileFsSvc(rootPath)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
if err := fsSvc.CreateDir(path); err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
return GetDataResponse[any](nil)
return GetVoidResponse()
}
func PostBaseFileRename(rootPath, path, newPath string) (response *Response[any], err error) {
func PostBaseFileRename(rootPath, path, newPath string) (response *VoidResponse, err error) {
fsSvc, err := fs.GetBaseFileFsSvc(rootPath)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
if err := fsSvc.Rename(path, newPath); err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
return GetDataResponse[any](nil)
return GetVoidResponse()
}
func DeleteBaseFile(rootPath, path string) (response *Response[any], err error) {
func DeleteBaseFile(rootPath, path string) (response *VoidResponse, err error) {
if path == "~" {
path = "."
}
fsSvc, err := fs.GetBaseFileFsSvc(rootPath)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
if err := fsSvc.Delete(path); err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
_, err = fsSvc.GetFileInfo(".")
if err != nil {
_ = fsSvc.CreateDir("/")
}
return GetDataResponse[any](nil)
return GetVoidResponse()
}
func PostBaseFileCopy(rootPath, path, newPath string) (response *Response[any], err error) {
func PostBaseFileCopy(rootPath, path, newPath string) (response *VoidResponse, err error) {
fsSvc, err := fs.GetBaseFileFsSvc(rootPath)
if err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
if err := fsSvc.Copy(path, newPath); err != nil {
return GetErrorResponse[any](err)
return GetErrorVoidResponse(err)
}
return GetDataResponse[any](nil)
return GetVoidResponse()
}
func PostBaseFileExport(rootPath string, c *gin.Context) (err error) {